integrate read_ru into tiflash resource control #8097
Conversation
Signed-off-by: guo-shaoge <shaoge1994@163.com>
Signed-off-by: guo-shaoge <shaoge1994@163.com>
|
/cc @JinheLin |
dbms/src/Server/Server.cpp
Outdated
| LocalAdmissionController::global_instance = std::make_unique<LocalAdmissionController>( | ||
| tmt_context.getKVCluster(), | ||
| tmt_context.getEtcdClient(), | ||
| global_context->getSettingsRef().enable_pipeline); |
There was a problem hiding this comment.
But it is need to restart TiFlash to enable the pipeline.
So there may be enable pipeline but disable resource control
There was a problem hiding this comment.
I think no need to support enable pipeline but disable resource control, just as we talked with PM.
PS: should change config name from enable_pipeline to enable_resource_control next pr.
dbms/src/Storages/DeltaMerge/ColumnFile/ColumnFileSetReader.cpp
Outdated
Show resolved
Hide resolved
|
/run-all-tests |
|
/run-all-tests |
|
/run-all-tests |
Signed-off-by: guo-shaoge <shaoge1994@163.com>
Signed-off-by: guo-shaoge <shaoge1994@163.com>
…sh into resource_control_part_5
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JinheLin, SeaRise The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: guo-shaoge <shaoge1994@163.com>
|
@guo-shaoge: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests
If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
/hold |
…sh into resource_control_part_5
|
/run-all-tests |
Signed-off-by: guo-shaoge <shaoge1994@163.com>
|
/run-integration-test |
|
/run-integration-test |
|
/run-integration-test |
|
/merge |
What problem does this PR solve?
Issue Number: close #8098
Problem Summary:
What is changed and how it works?
enable_pipelineto control LAC stopped or not. If LAC is stopped, no bg threads will start, and all public member functions of LAC is dummy.read_ruinto LAC, soRCQwill notice the consumption ofread_ru, also RU consmpution will report to GAC.enable_pipeline->enable_resource_control;enforce_enable_pipeline->enforce_enable_resource_controlCheck List
Tests
left panel: metric from token bucket;
right panel: metric from https://github.com/pingcap/tiflash/blob/master/dbms/src/Flash/Mpp/MPPTask.cpp#L578
Side effects
Documentation
Release note