Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip first state change of EXCHANGE Partition. #7945

Merged
merged 6 commits into from
Aug 22, 2023
Merged

Skip first state change of EXCHANGE Partition. #7945

merged 6 commits into from
Aug 22, 2023

Conversation

mjonss
Copy link
Contributor

@mjonss mjonss commented Aug 16, 2023 •
edited by SeaRise
Loading

It only generates warnings/errors and the first state change does not affect TiFlash, it only sets an internal field ExchangePartitionInfo

It is only the second stage transition that is interesting for TiFlash

Should be combined with pingcap/tidb#46125

What problem does this PR solve?

Issue Number: close #7941

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@mjonss
Skip first state change of EXCHANGE Partition.
e08812a 
It only generates warnings/errors and the first state change
does not affect TiFlash, it only sets an internal field
ExchangePartitionInfo

It is only the second stage transition that is interesting for TiFlash
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 16, 2023
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 16, 2023
@SeaRise
Copy link
Contributor

SeaRise commented Aug 16, 2023

tiflash/tests/fullstack-test2/ddl/alter_exchange_partition.test

Lines 15 to 16 in c7bce89

# enable this test after https://github.com/pingcap/tiflash/issues/7941 is fixed
#RETURN

alter_exchange_partition.test also need to be enabled in this pr

@SeaRise
Copy link
Contributor

SeaRise commented Aug 16, 2023

/check-issue-triage-complete

xzhangxian1008
xzhangxian1008 approved these changes Aug 16, 2023
View reviewed changes
Copy link
Contributor

@xzhangxian1008 xzhangxian1008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Aug 16, 2023
@xzhangxian1008
Copy link
Contributor

Please format your code with

python3 format-diff.py --diff_from `git merge-base xxx/master HEAD`

@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 22, 2023
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 22, 2023
@JaySon-Huang
Copy link
Contributor

/run-all-tests

@ti-chi-bot ti-chi-bot bot added the lgtm label Aug 22, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 22, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JaySon-Huang, xzhangxian1008

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Aug 22, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 22, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-08-16 08:14:03.687870601 +0000 UTC m=+705208.236886587: ☑️ agreed by xzhangxian1008.
  • 2023-08-22 07:37:48.072837493 +0000 UTC m=+1221432.621853476: ☑️ agreed by JaySon-Huang.

@ti-chi-bot ti-chi-bot bot added the approved label Aug 22, 2023
@JaySon-Huang
Copy link
Contributor

/run-all-tests

@ti-chi-bot ti-chi-bot bot merged commit b1f1dbc into pingcap:master Aug 22, 2023
@mjonss mjonss deleted the exchange-partition-skip-first-state branch August 22, 2023 08:49
@JaySon-Huang
Copy link
Contributor

/cherry-pick release-6.5

@ti-chi-bot ti-chi-bot mentioned this pull request Sep 15, 2023
Merged
12 tasks
@ti-chi-bot
Copy link
Member

@JaySon-Huang: new pull request created to branch release-6.5: #8099.

In response to this:

/cherry-pick release-6.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Sep 15, 2023
@mjonss @ti-chi-bot
This is an automated cherry-pick of pingcap#7945
65ef946 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@JaySon-Huang
Copy link
Contributor

/cherry-pick release-7.1

@ti-chi-bot ti-chi-bot mentioned this pull request Sep 15, 2023
Merged
12 tasks
@ti-chi-bot
Copy link
Member

@JaySon-Huang: new pull request created to branch release-7.1: #8100.

In response to this:

/cherry-pick release-7.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Sep 15, 2023
@mjonss @ti-chi-bot
This is an automated cherry-pick of pingcap#7945
bc8d769 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot bot pushed a commit that referenced this pull request Sep 17, 2023
@ti-chi-bot
Skip first state change of EXCHANGE Partition. (#7945) (#8099)
d21cded 
close #7941
ti-chi-bot bot pushed a commit that referenced this pull request Sep 19, 2023
@ti-chi-bot
Skip first state change of EXCHANGE Partition. (#7945) (#8100)
65a9f86 
close #7941
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JaySon-Huang JaySon-Huang JaySon-Huang approved these changes

@xzhangxian1008 xzhangxian1008 xzhangxian1008 approved these changes

Assignees
No one assigned
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fullstack test alter_exchange_partition.test hangs
5 participants
@mjonss @SeaRise @xzhangxian1008 @JaySon-Huang @ti-chi-bot