Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add UniversalPageStorage #6723

Merged
merged 29 commits into from
Feb 7, 2023
Merged

add UniversalPageStorage #6723

merged 29 commits into from
Feb 7, 2023

Conversation

lidezhu
Copy link
Contributor

@lidezhu lidezhu commented Feb 2, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #6728

Problem Summary:

What is changed and how it works?

  1. Rename DB::PageId to PageIdU64;
  2. Make many classes like PageDirectory BlobStore a template;
  3. Add UniversalPageStorage which receive a string type page id;

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 2, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JaySon-Huang
  • breezewish

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-linked-issue do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 2, 2023
@lidezhu
Copy link
Contributor Author

lidezhu commented Feb 3, 2023

/run-all-tests

@lidezhu lidezhu changed the title [WIP] add UniversalPageStorage add UniversalPageStorage Feb 3, 2023
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 3, 2023
@lidezhu
Copy link
Contributor Author

lidezhu commented Feb 6, 2023

/rebuild

JaySon-Huang
JaySon-Huang approved these changes Feb 6, 2023
View reviewed changes
Copy link
Contributor

@JaySon-Huang JaySon-Huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 6, 2023
@lidezhu
Copy link
Contributor Author

lidezhu commented Feb 6, 2023

/rebuild

@lidezhu
Copy link
Contributor Author

lidezhu commented Feb 6, 2023

/rebuild

@lidezhu
Copy link
Contributor Author

lidezhu commented Feb 7, 2023

/rebuild

@lidezhu
Copy link
Contributor Author

lidezhu commented Feb 7, 2023

/rebuild

breezewish
breezewish approved these changes Feb 7, 2023
View reviewed changes
dbms/src/Storages/Page/Page.h
: page_id(INVALID_PAGE_ID)
explicit Page(PageIdU64 page_id_)
: page_id(page_id_)
, is_valid(true)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure, but may be we can treat empty string as not valid.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Page struct is both used in PS V3 and Uni PS, so the PageId can be UInt128 or String.
And we extract a UInt64 from them and pass it to Page for easy adaption to previous code. So page_id should be a UInt64 here. Or it should be removed totally.

dbms/src/Storages/Page/V3/Universal/UniversalPageId.h
{
WriteBufferFromOwnString buff;
writeString(prefix, buff);
UniversalPageIdFormat::encodeUInt64(page_id, buff);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes our universal page id hard to interpret by human (because we always format as hex). Not sure whether this is a good idea..

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will also provide page-ctl tools for uni ps to dump its data. So this should be ok.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 7, 2023
@lidezhu
Copy link
Contributor Author

lidezhu commented Feb 7, 2023

/merge

@ti-chi-bot
Copy link
Member

@lidezhu: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: acde588

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 7, 2023
@lidezhu
Copy link
Contributor Author

lidezhu commented Feb 7, 2023

/run-unit-test

@lidezhu
Copy link
Contributor Author

lidezhu commented Feb 7, 2023

/run-all-tests

@lidezhu
Copy link
Contributor Author

lidezhu commented Feb 7, 2023

/rebuild

@lidezhu
Copy link
Contributor Author

lidezhu commented Feb 7, 2023

/run-integration-test

@lidezhu
Copy link
Contributor Author

lidezhu commented Feb 7, 2023

/run-unit-test

@ti-chi-bot ti-chi-bot merged commit 584c992 into pingcap:master Feb 7, 2023
@lidezhu lidezhu deleted the add-uni-ps-master branch February 7, 2023 12:40
ywqzzy pushed a commit to ywqzzy/tiflash_1 that referenced this pull request Feb 13, 2023
@lidezhu @ywqzzy
add UniversalPageStorage (pingcap#6723)
4f8b55a 
ref pingcap#6728

Signed-off-by: ywqzzy <592838129@qq.com>
@JaySon-Huang JaySon-Huang mentioned this pull request Feb 23, 2023
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@breezewish breezewish breezewish approved these changes

@JaySon-Huang JaySon-Huang JaySon-Huang approved these changes

@flowbehappy flowbehappy Awaiting requested review from flowbehappy

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lidezhu @ti-chi-bot @breezewish @JaySon-Huang