Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PageStorage: Refactor config #6138

Merged
merged 4 commits into from
Oct 14, 2022

Conversation

JaySon-Huang
Copy link
Contributor

@JaySon-Huang JaySon-Huang commented Oct 14, 2022

What problem does this PR solve?

Issue Number: ref #6071

Problem Summary:
Split from #6062, move some refactor as a standalone PR

What is changed and how it works?

Just some renaming, no logical change

Move PageStorage::Config -> PageStorageConfig
Move PageStorageImpl:: parseBlobConfig -> BlobConfig::from(PageStorageConfig)
Move PageStorageImpl:: parseWALConfig -> WALConfig::from(PageStorageConfig)
Move WriteBatch::WriteType -> WriteBatchWriteType

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

JaySon-Huang and others added 4 commits October 14, 2022 17:17
Signed-off-by: JaySon-Huang <tshent@qq.com>
Signed-off-by: JaySon-Huang <tshent@qq.com>
Signed-off-by: JaySon-Huang <tshent@qq.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 14, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • CalvinNeo
  • Lloyd-Pottiger

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 14, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 14, 2022
Copy link
Member

@CalvinNeo CalvinNeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 14, 2022
@JaySon-Huang
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

@JaySon-Huang: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 69167bf

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 14, 2022
@Lloyd-Pottiger
Copy link
Contributor

/run-unit-test

@ti-chi-bot ti-chi-bot merged commit 100fad7 into pingcap:master Oct 14, 2022
@JaySon-Huang JaySon-Huang deleted the refactor_blobstore branch October 14, 2022 10:43
JaySon-Huang added a commit to JaySon-Huang/tiflash that referenced this pull request Oct 19, 2022
JaySon-Huang added a commit to JaySon-Huang/tiflash that referenced this pull request Oct 21, 2022
JaySon-Huang added a commit to JaySon-Huang/tiflash that referenced this pull request Oct 21, 2022
JaySon-Huang added a commit to JaySon-Huang/tiflash that referenced this pull request Oct 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants