TestUtils: read all blocks and sort them by handle before comparison. #5745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
|
/run-all-tests |
d3521f1 to
495614c
Compare
|
/run-all-tests |
495614c to
b3f47d7
Compare
|
/run-all-tests |
b3f47d7 to
f864c2d
Compare
|
/run-all-tests |
f864c2d to
06f8189
Compare
06f8189 to
9819cd3
Compare
|
/run-all-tests |
Coverage for changed filesCoverage summaryfull coverage report (for internal network access only) |
|
/run-unit-test |
Coverage for changed filesCoverage summaryfull coverage report (for internal network access only) |
|
/run-unit-test |
Coverage for changed filesCoverage summaryfull coverage report (for internal network access only) |
|
/run-all-tests |
|
/cc @ywqzzy |
Coverage for changed filesCoverage summaryfull coverage report (for internal network access only) |
ywqzzy
reviewed
Sep 1, 2022
Co-authored-by: yanweiqi <592838129@qq.com>
ywqzzy
reviewed
Sep 1, 2022
Co-authored-by: yanweiqi <592838129@qq.com>
|
/merge |
|
@JinheLin: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger If you have any questions about the PR merge process, please refer to pr process. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
This pull request has been accepted and is ready to merge. Commit hash: db82f7e
|
Coverage for changed filesCoverage summaryfull coverage report (for internal network access only) |
|
@JinheLin: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Coverage for changed filesCoverage summaryfull coverage report (for internal network access only) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: ref #5689
Problem Summary:
Blocks can be unordered when read-thread-pool enabled if there are more than one segments.
To simplify testing, read all blocks and sort them by handle column before comparison.
What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note