Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove useless experimental configurations of read thread pool. #5730

Merged
merged 2 commits into from
Aug 30, 2022
Merged

Remove useless experimental configurations of read thread pool. #5730

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8f13523
Remove useless configurations of read thread pool.
JinheLin Aug 29, 2022
c8099cc
Merge branch 'master' into rm_config
ti-chi-bot Aug 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions dbms/src/Interpreters/Settings.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,8 +317,6 @@ struct Settings
\
M(SettingDouble, dt_page_gc_threshold, 0.5, "Max valid rate of deciding to do a GC in PageStorage") \
M(SettingBool, dt_enable_read_thread, false, "Enable storage read thread or not") \
M(SettingDouble, dt_block_slots_scale, 1.0, "Block slots limit of a read request") \
M(SettingDouble, dt_active_segments_scale, 1.0, "Acitve segments limit of a read request") \
\
M(SettingChecksumAlgorithm, dt_checksum_algorithm, ChecksumAlgo::XXH3, "Checksum algorithm for delta tree stable storage") \
M(SettingCompressionMethod, dt_compression_method, CompressionMethod::LZ4, "The method of data compression when writing.") \
Expand Down
6 changes: 2 additions & 4 deletions dbms/src/Storages/DeltaMerge/SegmentReadTaskPool.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,8 +222,7 @@ int64_t SegmentReadTaskPool::decreaseUnorderedInputStreamRefCount()

int64_t SegmentReadTaskPool::getFreeBlockSlots() const
{
double block_slots_scale = dm_context->db_context.getSettingsRef().dt_block_slots_scale;
auto block_slots = static_cast<int64_t>(std::ceil(unordered_input_stream_ref_count.load(std::memory_order_relaxed) * block_slots_scale));
auto block_slots = unordered_input_stream_ref_count.load(std::memory_order_relaxed);
if (block_slots < 3)
{
block_slots = 3;
Expand All @@ -233,8 +232,7 @@ int64_t SegmentReadTaskPool::getFreeBlockSlots() const

int64_t SegmentReadTaskPool::getFreeActiveSegmentCountUnlock()
{
double active_segments_scale = dm_context->db_context.getSettingsRef().dt_active_segments_scale;
auto active_segment_limit = static_cast<int64_t>(std::ceil(unordered_input_stream_ref_count.load(std::memory_order_relaxed) * active_segments_scale));
auto active_segment_limit = unordered_input_stream_ref_count.load(std::memory_order_relaxed);
if (active_segment_limit < 2)
{
active_segment_limit = 2;
Expand Down