Skip to content

Commit

Permalink
fix build
Browse files Browse the repository at this point in the history
Signed-off-by: guo-shaoge <shaoge1994@163.com>
  • Loading branch information
guo-shaoge committed Mar 29, 2023
1 parent df04360 commit ed80d6f
Show file tree
Hide file tree
Showing 3 changed files with 19 additions and 3 deletions.
7 changes: 4 additions & 3 deletions dbms/src/Flash/Coprocessor/DAGStorageInterpreter.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -963,12 +963,13 @@ std::tuple<Names, NamesAndTypes, std::vector<ExtraCastAfterTSMode>> DAGStorageIn
for (Int32 i = 0; i < table_scan.getColumnSize(); ++i)
{
auto const & ci = table_scan.getColumns()[i];
auto tidb_ci = TiDB::toTiDBColumnInfo(ci);
ColumnID cid = ci.column_id();

if (ci.has_flag() && ((ci.flag() & TiDB::ColumnFlagGeneratedColumn) != 0))
if (tidb_ci.hasGeneratedColumnFlag())
{
LOG_DEBUG(log, "got column({}) with generated column flag", i);
const auto & data_type = getDataTypeByColumnInfoForComputingLayer(ci);
LOG_FMT_DEBUG(log, "got column({}) with generated column flag", i);
const auto & data_type = getDataTypeByColumnInfoForComputingLayer(tidb_ci);
const auto & col_name = GeneratedColumnPlaceholderBlockInputStream::getColumnName(i);
generated_column_infos.push_back(std::make_tuple(i, col_name, data_type));
source_columns_tmp.emplace_back(NameAndTypePair{col_name, data_type});
Expand Down
13 changes: 13 additions & 0 deletions dbms/src/Storages/Transaction/TiDB.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1128,4 +1128,17 @@ ColumnInfo fieldTypeToColumnInfo(const tipb::FieldType & field_type)
return ret;
}

ColumnInfo toTiDBColumnInfo(const tipb::ColumnInfo & tipb_column_info)
{
ColumnInfo tidb_column_info;
tidb_column_info.tp = static_cast<TiDB::TP>(tipb_column_info.tp());
tidb_column_info.id = tipb_column_info.column_id();
tidb_column_info.flag = tipb_column_info.flag();
tidb_column_info.flen = tipb_column_info.columnlen();
tidb_column_info.decimal = tipb_column_info.decimal();
for (int i = 0; i < tipb_column_info.elems_size(); ++i)
tidb_column_info.elems.emplace_back(tipb_column_info.elems(i), i + 1);
return tidb_column_info;
}

} // namespace TiDB
2 changes: 2 additions & 0 deletions dbms/src/Storages/Transaction/TiDB.h
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
#include <IO/WriteHelpers.h>
#include <Storages/Transaction/StorageEngineType.h>
#include <Storages/Transaction/Types.h>
#include <tipb/schema.pb.h>

#include <optional>

Expand Down Expand Up @@ -413,5 +414,6 @@ String genJsonNull();

tipb::FieldType columnInfoToFieldType(const ColumnInfo & ci);
ColumnInfo fieldTypeToColumnInfo(const tipb::FieldType & field_type);
ColumnInfo toTiDBColumnInfo(const tipb::ColumnInfo & tipb_column_info);

} // namespace TiDB

0 comments on commit ed80d6f

Please sign in to comment.