Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plugin: add audit plugin extension point #9136

Merged
merged 8 commits into from
Mar 25, 2019
Merged

plugin: add audit plugin extension point #9136

merged 8 commits into from
Mar 25, 2019

Conversation

lysu
Copy link
Contributor

@lysu lysu commented Jan 21, 2019 •
edited
Loading

What problem does this PR solve?

to support audit plugin

What is changed and how it works?

add extension point and pass enough information into plugin.

Check List

Tests

  • WIP

Code changes

  • Has exported function/method change
  • Has interface methods change

Side effects

  • N/A

Related changes

  • N/A

This change is Reviewable

@lysu
Copy link
Contributor Author

lysu commented Feb 11, 2019

this pr also need pingcap/parser#32 to mask insensitive data

@lysu lysu mentioned this pull request Feb 14, 2019
Merged
tiancaiamao
tiancaiamao reviewed Feb 15, 2019
View reviewed changes
Copy link
Contributor

@tiancaiamao tiancaiamao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's better to split audit plugin extension point and flush plugin into two PRs

@lysu lysu mentioned this pull request Feb 15, 2019
Merged
@codecov-io
Copy link

codecov-io commented Feb 18, 2019 •
edited by codecov bot
Loading

Codecov Report

Merging #9136 into master will decrease coverage by 0.0546%.
The diff coverage is 26.7942%.

@@               Coverage Diff                @@
##             master      #9136        +/-   ##
================================================
- Coverage   67.3545%   67.2999%   -0.0547%     
================================================
  Files           383        385         +2     
  Lines         80437      80587       +150     
================================================
+ Hits          54178      54235        +57     
- Misses        21417      21498        +81     
- Partials       4842       4854        +12

tiancaiamao
tiancaiamao reviewed Feb 20, 2019
View reviewed changes
@tiancaiamao
Copy link
Contributor

OK, I'll review it when it's ready.
Kind remind: don't make a PR too large

@lysu
Copy link
Contributor Author

lysu commented Feb 22, 2019

@tiancaiamao ok~

@lysu lysu added type/TEP and removed status/WIP labels Mar 13, 2019
@lysu
Copy link
Contributor Author

lysu commented Mar 13, 2019

@tiancaiamao @jackysp PTAL when free thx~

@lysu lysu requested a review from jackysp March 13, 2019 12:23
tiancaiamao
tiancaiamao reviewed Mar 14, 2019
View reviewed changes
@tiancaiamao
Copy link
Contributor

Rest LGTM
PTAL @jackysp

@tiancaiamao tiancaiamao added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 14, 2019
@tiancaiamao
Copy link
Contributor

LGTM

jackysp
jackysp previously approved these changes Mar 18, 2019
View reviewed changes
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp
Copy link
Member

jackysp commented Mar 18, 2019

/run-all-tests

@lysu
Copy link
Contributor Author

lysu commented Mar 21, 2019

/run-common-test

@lysu lysu removed the status/DNM label Mar 21, 2019
@lysu
Copy link
Contributor Author

lysu commented Mar 21, 2019

/run-all-tests

1 similar comment
@lysu
Copy link
Contributor Author

lysu commented Mar 21, 2019

/run-all-tests

jackysp
jackysp previously approved these changes Mar 22, 2019
View reviewed changes
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason
Copy link
Member

@lysu CI failed.

@lysu
Copy link
Contributor Author

lysu commented Mar 25, 2019

/run-all-tests

@lysu
Copy link
Contributor Author

lysu commented Mar 25, 2019

/run-unit-test

@lysu lysu added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 25, 2019
@lysu lysu merged commit 0313cbb into pingcap:master Mar 25, 2019
@lysu lysu deleted the dev-audit-plugin-extension-point branch March 28, 2019 12:07
@lysu lysu mentioned this pull request Mar 29, 2019
Merged
zz-jason pushed a commit that referenced this pull request Apr 4, 2019
@lysu @zz-jason
plugin: add audit plugin extension point (#9136) (#9954)
0896d15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiancaiamao tiancaiamao tiancaiamao approved these changes

@jackysp jackysp jackysp left review comments

Assignees
No one assigned
Labels
component/plugin status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lysu @codecov-io @tiancaiamao @jackysp @zz-jason