expression: fix date_add interval month,year diffs from mysql #8988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #8988 +/- ##
==========================================
- Coverage 67.26% 67.26% -0.01%
==========================================
Files 371 371
Lines 77161 77182 +21
==========================================
+ Hits 51905 51916 +11
- Misses 20620 20633 +13
+ Partials 4636 4633 -3
Continue to review full report at Codecov.
|
|
/run-all-tests |
imtbkcat
reviewed
Jan 14, 2019
expression/builtin_time.go
Outdated
| goTime = goTime.AddDate(int(year), int(month), int(day)) | ||
| // when we execute select date_add('2018-01-31',interval 1 month) in mysql we got 2018-02-28 | ||
| // but in tidb we got 2018-03-03 | ||
| // dig it and we found it's caused by golang api time.DateDate(year int, month Month, day, hour, min, sec, nsec int, loc *Location) Time , |
There was a problem hiding this comment.
Please uppercase the first letter of each comment sentence.
uppercase the first letter of each comment sentence.
qw4990
reviewed
Jan 23, 2019
expression/builtin_time.go
Outdated
| goTime = goTime.AddDate(int(year), int(month), int(day)) | ||
| // When we execute select date_add('2018-01-31',interval 1 month) in mysql we got 2018-02-28 | ||
| // but in tidb we got 2018-03-03. | ||
| // Dig it and we found it's caused by golang api time.DateDate(year int, month Month, day, hour, min, sec, nsec int, loc *Location) Time , |
qw4990
reviewed
Jan 23, 2019
expression/builtin_time.go
Outdated
| // Dig it and we found it's caused by golang api time.DateDate(year int, month Month, day, hour, min, sec, nsec int, loc *Location) Time , | ||
| // it says October 32 converts to November 1 ,it conflits with mysql. | ||
| // See https://dev.mysql.com/doc/refman/5.7/en/date-and-time-functions.html#function_date-add | ||
| df := getFixDays(int(year), int(month), int(day), goTime) |
There was a problem hiding this comment.
It's better to wrap these to a more easy-to-use function like dateAdd(goTime, year, month, day) goTime?
There was a problem hiding this comment.
I've modified as you suggested.
PTAL @qw4990
|
LGTM |
qw4990
approved these changes
Feb 11, 2019
|
@haplone Thanks for your contribution~ Can you help us to cherry pick this commit to release-2.1 and release-2.0? |
haplone
added a commit
to haplone/tidb
that referenced
this pull request
Feb 12, 2019
haplone
added a commit
to haplone/tidb
that referenced
this pull request
Feb 12, 2019
zimulala
pushed a commit
that referenced
this pull request
Feb 13, 2019
zimulala
pushed a commit
that referenced
this pull request
Feb 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
date_add interval month diffs from mysql
when we execute select date_add('2018-01-31',interval 1 month) in mysql we got 2018-02-28
but in tidb we got 2018-03-03
What is changed and how it works?
Check List
Tests