Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: add TiDB version to metrics #7902

Merged
merged 6 commits into from
Oct 18, 2018
Merged

ddl: add TiDB version to metrics #7902

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9df619c
ddl: add TiDB version to metrics
zimulala Oct 15, 2018
d68dc9e
Merge branch 'master' into add-ver
crazycs520 Oct 16, 2018
4b9058d
Merge branch 'master' into add-ver
crazycs520 Oct 16, 2018
d0f4ff7
Merge branch 'master' into add-ver
crazycs520 Oct 17, 2018
e001b41
Merge branch 'master' into add-ver
zimulala Oct 18, 2018
975d958
Merge branch 'master' into add-ver
winoros Oct 18, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ddl/ddl.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,7 +261,7 @@ func (dc *ddlCtx) isOwner() bool {
isOwner := dc.ownerManager.IsOwner()
log.Debugf("[ddl] it's the DDL owner %v, self ID %s", isOwner, dc.uuid)
if isOwner {
metrics.DDLCounter.WithLabelValues(metrics.IsDDLOwner).Inc()
metrics.DDLCounter.WithLabelValues(metrics.DDLOwner + "_" + mysql.TiDBReleaseVersion).Inc()
}
return isOwner
}
Expand Down
2 changes: 1 addition & 1 deletion metrics/ddl.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ var (

CreateDDLInstance = "create_ddl_instance"
CreateDDL = "create_ddl"
IsDDLOwner = "is_ddl_owner"
DDLOwner = "owner"
DDLCounter = prometheus.NewCounterVec(
prometheus.CounterOpts{
Namespace: "tidb",
Expand Down