Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

table: Revert "table: fix the issue that the default value for BIT column is wrong (#57303)" #59840

Merged

Conversation

Rustin170506
Copy link
Member

@Rustin170506 Rustin170506 commented Feb 28, 2025

Reverts #57356 because of #59759

What problem does this PR solve?

Issue Number: ref #59759

We'll need to reconsider the solution / bugfix for both issues before the next release of 7.5.

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 28, 2025
@Rustin170506 Rustin170506 added skip-issue-check Indicates that a PR no need to check linked issue. and removed skip-issue-check Indicates that a PR no need to check linked issue. labels Feb 28, 2025
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. do-not-merge/cherry-pick-not-approved labels Feb 28, 2025
Copy link
Contributor

@fixdb fixdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Feb 28, 2025
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 28, 2025
Copy link

ti-chi-bot bot commented Feb 28, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-02-28 06:06:05.936036499 +0000 UTC m=+595113.889194764: ☑️ agreed by fixdb.
  • 2025-02-28 06:12:03.555972552 +0000 UTC m=+595471.509130818: ☑️ agreed by time-and-fate.

Copy link

codecov bot commented Feb 28, 2025

Codecov Report

Attention: Patch coverage is 79.31034% with 6 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-7.5@48e8060). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-7.5     #59840   +/-   ##
================================================
  Coverage               ?   72.2918%           
================================================
  Files                  ?       1417           
  Lines                  ?     414470           
  Branches               ?          0           
================================================
  Hits                   ?     299628           
  Misses                 ?      94896           
  Partials               ?      19946           
Flag Coverage Δ
unit 72.2918% <79.3103%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9400% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 53.5986% <0.0000%> (?)

Copy link

ti-chi-bot bot commented Feb 28, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fixdb, time-and-fate, wjhuang2016

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Feb 28, 2025
@Rustin170506
Copy link
Member Author

/retest

@ti-chi-bot ti-chi-bot bot merged commit f471bdf into release-7.5 Feb 28, 2025
17 of 18 checks passed
@ti-chi-bot ti-chi-bot bot deleted the revert-57356-cherry-pick-57303-to-release-7.5 branch February 28, 2025 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants