Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

table: Revert "table: fix the issue that the default value for BIT column is wrong (#57303)" #59768

Merged

Conversation

YangKeao
Copy link
Member

@YangKeao YangKeao commented Feb 26, 2025

Reverts #57354 because of #59759

close #59769

We'll need to reconsider the solution / bugfix for both issues before the next release of 6.5.

@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 26, 2025
@YangKeao YangKeao added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Feb 26, 2025
Copy link
Member

@Rustin170506 Rustin170506 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! :shipit:

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 26, 2025
Copy link

ti-chi-bot bot commented Feb 26, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, Rustin170506

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Rustin170506,hawkingrei]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 26, 2025
Copy link

ti-chi-bot bot commented Feb 26, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-02-26 04:06:29.192364901 +0000 UTC m=+415137.145523161: ☑️ agreed by Rustin170506.
  • 2025-02-26 04:08:34.223330016 +0000 UTC m=+415262.176488282: ☑️ agreed by hawkingrei.

@YangKeao YangKeao linked an issue Feb 26, 2025 that may be closed by this pull request
@ti-chi-bot ti-chi-bot bot added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Feb 26, 2025
Copy link

codecov bot commented Feb 26, 2025

Codecov Report

Attention: Patch coverage is 89.65517% with 3 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-6.5@0f05777). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-6.5     #59768   +/-   ##
================================================
  Coverage               ?   73.6432%           
================================================
  Files                  ?       1098           
  Lines                  ?     353666           
  Branches               ?          0           
================================================
  Hits                   ?     260451           
  Misses                 ?      76480           
  Partials               ?      16735           

@ti-chi-bot ti-chi-bot bot merged commit 2ec3e3e into release-6.5 Feb 26, 2025
10 checks passed
@ti-chi-bot ti-chi-bot bot deleted the revert-57354-cherry-pick-57303-to-release-6.5 branch February 26, 2025 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Data Too Long, field len X in stats loader for release-6.5 branch
3 participants