-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
infoschema: avoid strings.toUpper in the IsClusterTableByName #59608
Conversation
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #59608 +/- ##
================================================
+ Coverage 73.0128% 74.7753% +1.7625%
================================================
Files 1694 1740 +46
Lines 468330 480808 +12478
================================================
+ Hits 341941 359526 +17585
+ Misses 105359 98660 -6699
- Partials 21030 22622 +1592
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
/retest |
1 similar comment
/retest |
[LGTM Timeline notifier]Timeline:
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Defined2014, tangenta, winoros The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What problem does this PR solve?
Issue Number: close #59606
Problem Summary:
What changed and how does it work?
in fact, They have been upper.
memTableToAllTiDBClusterTables
andmemTableToDDLOwnerClusterTables
have been upper. the parameters of IsClusterTableByName have been upper, too.Check List
Tests
before
after
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.