-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lightning/importinto: set correct step to create single point allocator (#56602) #59570
base: release-6.5
Are you sure you want to change the base?
lightning/importinto: set correct step to create single point allocator (#56602) #59570
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@D3Hunter This PR has conflicts, I have hold it. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@ti-chi-bot: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This cherry pick PR is for a release branch and has not yet been approved by triage owners. To merge this cherry pick:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This is an automated cherry-pick of #56602
What problem does this PR solve?
Issue Number: close #56476
Problem Summary:
What changed and how does it work?
we must set
autoid.CustomAutoIncCacheOption(1)
to create a new single point allocator, else it's always normal oneCheck List
Tests
import into is test manually with same case as lightning. when I try add to real-tikv-test, it report
autoid service leader not found
, something might not be mocked.Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.