-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lightning: unlimited grpc MaxCallRecvMsgSize for TikvImporter (#56771) #59569
lightning: unlimited grpc MaxCallRecvMsgSize for TikvImporter (#56771) #59569
Conversation
d631182
to
d749bba
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-6.5 #59569 +/- ##
================================================
Coverage ? 73.7175%
================================================
Files ? 1098
Lines ? 354050
Branches ? 0
================================================
Hits ? 260997
Misses ? 76333
Partials ? 16720 |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: D3Hunter, tangenta The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
This is an automated cherry-pick of #56771
What problem does this PR solve?
Issue Number: close #56114
Problem Summary: Currently, we comply with the default max-message-size=4MiB, but TiKVImporter may receive max 4k KV on each response, and each KV can be about 4KiB+, which exceeds the default limit easily.
What changed and how does it work?
Set grpc options
MaxCallRecvMsgSize
to math.MaxInt32 (2GiB), i.e., unlimited in most scenarios. This number also aligns with the default setting for MaxCallSendMsgSize in gRPC.MaxCallRecvMsgSize is only for resource control and there will not be any extra memory consumption. Please refer to the discussions below.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.