Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: fix unstable test TestCreateDropCreateTable (#50076) #59568

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #50076

What problem does this PR solve?

Issue Number: close #50061

Problem Summary:

There is a gap between runningJobs.remove() and next runningJobs.add(). If getJob() is invoked during this gap, DDL worker may execute the second create table job first.

What changed and how does it work?

This PR distinguishes the concept between "processing" jobs and "unfinished" jobs:

  • Processing jobs: activatly running by a DDL worker.
  • Unfinished jobs: the jobs whose state is NOT synced, done, or rollback done.

For checkRunnable(), we should use "unfinished jobs" to determine the dependency.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels Feb 17, 2025
@ti-chi-bot
Copy link
Member Author

@tangenta This PR has conflicts, I have hold it.
Please resolve them or ask others to resolve them, then comment /unhold to remove the hold label.

@tangenta tangenta removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 17, 2025
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 17, 2025
Copy link

ti-chi-bot bot commented Feb 17, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tangenta, wjhuang2016

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [tangenta,wjhuang2016]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 17, 2025
Copy link

ti-chi-bot bot commented Feb 17, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-02-17 06:43:29.937668212 +0000 UTC m=+857252.333890269: ☑️ agreed by tangenta.
  • 2025-02-17 07:36:12.844796585 +0000 UTC m=+860415.241018646: ☑️ agreed by wjhuang2016.

@tangenta
Copy link
Contributor

/retest

Copy link

codecov bot commented Feb 17, 2025

Codecov Report

Attention: Patch coverage is 77.77778% with 12 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-6.5@19843ce). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-6.5     #59568   +/-   ##
================================================
  Coverage               ?   73.6426%           
================================================
  Files                  ?       1098           
  Lines                  ?     353620           
  Branches               ?          0           
================================================
  Hits                   ?     260415           
  Misses                 ?      76464           
  Partials               ?      16741           

@ti-chi-bot ti-chi-bot bot merged commit 5526691 into pingcap:release-6.5 Feb 17, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants