-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ddl: fix unstable test TestCreateDropCreateTable (#50076) #59568
ddl: fix unstable test TestCreateDropCreateTable (#50076) #59568
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@tangenta This PR has conflicts, I have hold it. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tangenta, wjhuang2016 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
/retest |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-6.5 #59568 +/- ##
================================================
Coverage ? 73.6426%
================================================
Files ? 1098
Lines ? 353620
Branches ? 0
================================================
Hits ? 260415
Misses ? 76464
Partials ? 16741 |
This is an automated cherry-pick of #50076
What problem does this PR solve?
Issue Number: close #50061
Problem Summary:
There is a gap between
runningJobs.remove()
and nextrunningJobs.add()
. IfgetJob()
is invoked during this gap, DDL worker may execute the secondcreate table
job first.What changed and how does it work?
This PR distinguishes the concept between "processing" jobs and "unfinished" jobs:
synced
,done
, orrollback done
.For
checkRunnable()
, we should use "unfinished jobs" to determine the dependency.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.