-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: Using converted value in newBatchPointGetPlan, fix for partitioned table and IN (#57011) #59325
planner: Using converted value in newBatchPointGetPlan, fix for partitioned table and IN (#57011) #59325
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
/retest |
1 similar comment
/retest |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-6.5 #59325 +/- ##
================================================
Coverage ? 73.6415%
================================================
Files ? 1097
Lines ? 353241
Branches ? 0
================================================
Hits ? 260132
Misses ? 76357
Partials ? 16752 |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Defined2014, lcwangchao The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
This is an automated cherry-pick of #57011
What problem does this PR solve?
Issue Number: close #54746
Problem Summary:
newBatchPointGetPlan()
did not use the converteddatum
resulting in no found row for partitioned tables that usedIN ()
with non-matching types.What changed and how does it work?
Using the converted
datum
, like it was done for some other item types.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.