-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: Do not allow variables in create view (#57474) #59323
planner: Do not allow variables in create view (#57474) #59323
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@mjonss This PR has conflicts, I have hold it. |
/retest |
1 similar comment
/retest |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-6.5 #59323 +/- ##
================================================
Coverage ? 74.1188%
================================================
Files ? 1097
Lines ? 356082
Branches ? 0
================================================
Hits ? 263924
Misses ? 75642
Partials ? 16516 |
/unhold |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Defined2014, lcwangchao The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
This is an automated cherry-pick of #57474
What problem does this PR solve?
Issue Number: close #53176
Problem Summary:
No check if there were variables in the CREATE VIEW statement.
What changed and how does it work?
Added a visitor to check for
VariableExpr
and give an error for such CREATE VIEWCheck List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.