-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expression: Disallow conv fuction with hybrid type argement to be pushed down to TiKV (#53502) #59294
expression: Disallow conv fuction with hybrid type argement to be pushed down to TiKV (#53502) #59294
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
16ff142
to
c75d20a
Compare
c75d20a
to
225972b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@yibin87: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/retest |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-7.5 #59294 +/- ##
================================================
Coverage ? 72.1573%
================================================
Files ? 1417
Lines ? 413449
Branches ? 0
================================================
Hits ? 298334
Misses ? 95108
Partials ? 20007
Flags with carried forward coverage won't be shown. Click here to find out more.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lcwangchao, XuHuaiyu, yibin87 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
This is an automated cherry-pick of #53502
What problem does this PR solve?
Issue Number: close #51877
Problem Summary:
What changed and how does it work?
As described in #51877, such case can't be supported in TiKV side, just disallow it to be pushed down.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.