-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
br: refactor test to use wait checkpoint method (#57612) #59283
br: refactor test to use wait checkpoint method (#57612) #59283
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@Tristan1900 This PR has conflicts, I have hold it. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-6.5 #59283 +/- ##
================================================
Coverage ? 74.4757%
================================================
Files ? 1098
Lines ? 359208
Branches ? 0
================================================
Hits ? 267523
Misses ? 75128
Partials ? 16557 |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 3pointer, BornChanger The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
/unhold |
This is an automated cherry-pick of #57612
What problem does this PR solve?
Issue Number: close #57609
Problem Summary:
What changed and how does it work?
Extract the wait for checkpoint to advance logic in integration test to a method
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.