*: avoid unlock of unlocked mutex panic on TableDeltaMap (#57799) #59063
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #57799
What problem does this PR solve?
Issue Number: close #57798
Problem Summary:
What changed and how does it work?
It's most likely that
unlock of unlocked mutex
is caused by the struct assignment that overwrite the mutex field.The old code is weird,tdmLock
is used to protectTableDeltaMap
but it's not goes together withTableDeltaMap
.I wrapTableDeltaMap
into a struct and provideClone()
andVisit()
function to it.Just tiny workaround!
Check List
Tests
Some kind of data race, not easy to check in the unit test way
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.