br: make table existence check unified on different br client

[RidRisR]

What problem does this PR solve?

Issue Number: close #58168

Problem Summary:

What changed and how does it work?

Remove the client check of tableExistenceCheck, now it works on both sql and cli client.

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

[tiprow]

Hi @RidRisR. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.7679%. Comparing base (1d53c85) to head (065fdee).
Report is 12 commits behind head on master.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #58211        +/-   ##
================================================
+ Coverage   73.2271%   74.7679%   +1.5408%     
================================================
  Files          1676       1691        +15     
  Lines        462084     463090      +1006     
================================================
+ Hits         338371     346243      +7872     
+ Misses       102947      95306      -7641     
- Partials      20766      21541       +775     

Flag	Coverage Δ
integration	46.3143% <ø> (?)
unit	72.3112% <ø> (-0.0543%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	52.6910% <ø> (ø)
parser	∅ <ø> (∅)
br	61.5931% <ø> (+15.6293%)	⬆️

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BornChanger, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• br/OWNERS [BornChanger,YuJuncen]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2024-12-12 10:24:48.717678653 +0000 UTC m=+520478.806481197: ☑️ agreed by YuJuncen.
• 2024-12-13 02:42:33.433321346 +0000 UTC m=+579143.522123887: ☑️ agreed by BornChanger.

[ti-chi-bot]

In response to a cherrypick label: new pull request created to branch release-8.1: #58244.

[ti-chi-bot]

In response to a cherrypick label: new pull request created to branch release-7.5: #58245.

[ti-chi-bot]

In response to a cherrypick label: new pull request created to branch release-8.5: #58262.

[ti-chi-bot]

In response to a cherrypick label: new pull request created to branch release-6.5: #58263.

[ti-chi-bot]

In response to a cherrypick label: new pull request created to branch release-7.1: #58264.

[ti-chi-bot]

@RidRisR: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-br-integration-test	26d27e2	link	true	/test pull-br-integration-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.