Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix the data race in restore test #57762

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

3pointer
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #57760

Problem Summary:
As issue describe.

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 27, 2024
Copy link

tiprow bot commented Nov 27, 2024

Hi @3pointer. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.5669%. Comparing base (ba791ab) to head (73571d4).
Report is 2 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #57762        +/-   ##
================================================
+ Coverage   72.8198%   74.5669%   +1.7470%     
================================================
  Files          1677       1692        +15     
  Lines        464144     464356       +212     
================================================
+ Hits         337989     346256      +8267     
+ Misses       105294      96650      -8644     
- Partials      20861      21450       +589     
Flag Coverage Δ
integration 46.7107% <ø> (?)
unit 72.2888% <ø> (+0.0713%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.7673% <ø> (ø)
parser ∅ <ø> (∅)
br 61.2267% <ø> (+15.5350%) ⬆️

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 27, 2024
Copy link

ti-chi-bot bot commented Nov 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 27, 2024
Copy link

ti-chi-bot bot commented Nov 27, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-27 08:17:35.47258047 +0000 UTC m=+624443.092234986: ☑️ agreed by hawkingrei.
  • 2024-11-27 09:01:14.913349717 +0000 UTC m=+627062.533004233: ☑️ agreed by YuJuncen.

@ti-chi-bot ti-chi-bot bot merged commit 0471081 into pingcap:master Nov 27, 2024
33 checks passed
YuJuncen pushed a commit to YuJuncen/tidb that referenced this pull request Jan 6, 2025
YuJuncen pushed a commit to YuJuncen/tidb that referenced this pull request Jan 16, 2025
@YuJuncen YuJuncen mentioned this pull request Jan 16, 2025
13 tasks
YuJuncen pushed a commit to YuJuncen/tidb that referenced this pull request Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DATA RACE in the TestSimpleRestorerImportAndProgress
3 participants