Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

br/operator: added some commands for managing migrations #56857

Merged
merged 5 commits into from
Nov 4, 2024

Conversation

YuJuncen
Copy link
Contributor

@YuJuncen YuJuncen commented Oct 28, 2024

What problem does this PR solve?

Issue Number: close #56760

Problem Summary:
We need some commands for operating log backup.

What changed and how does it work?

We added such commands. See the linked issue for more details.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Added three experimental commands for `br operator`: `list-migrations`(list compactions and truncated ts), `migrate-to`(remove compacted log files) and `base64ify`(convert storage url to base64, which is acceptable by `tikv-ctl`.)

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 28, 2024
Copy link

tiprow bot commented Oct 28, 2024

Hi @YuJuncen. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Oct 28, 2024
Copy link

codecov bot commented Oct 28, 2024

Codecov Report

Attention: Patch coverage is 14.23488% with 241 lines in your changes missing coverage. Please review.

Project coverage is 57.4911%. Comparing base (7292117) to head (8188883).
Report is 59 commits behind head on master.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #56857         +/-   ##
=================================================
- Coverage   73.2789%   57.4911%   -15.7879%     
=================================================
  Files          1636       1782        +146     
  Lines        453658     642652     +188994     
=================================================
+ Hits         332436     369468      +37032     
- Misses       100846     248614     +147768     
- Partials      20376      24570       +4194     
Flag Coverage Δ
integration 38.5720% <14.2348%> (?)
unit 72.9624% <14.2348%> (+0.4744%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9478% <ø> (ø)
parser ∅ <ø> (∅)
br 62.6612% <14.2348%> (+16.6813%) ⬆️

Signed-off-by: hillium <yujuncen@pingcap.com>
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 30, 2024
YuJuncen and others added 2 commits October 31, 2024 11:19
Signed-off-by: hillium <yujuncen@pingcap.com>
Copy link

ti-chi-bot bot commented Nov 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3pointer, Leavrth

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 4, 2024
Copy link

ti-chi-bot bot commented Nov 4, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-10-30 08:55:46.288063523 +0000 UTC m=+426459.127219068: ☑️ agreed by 3pointer.
  • 2024-11-04 09:06:10.567611442 +0000 UTC m=+859083.406766987: ☑️ agreed by Leavrth.

Copy link

tiprow bot commented Nov 4, 2024

@YuJuncen: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
fast_test_tiprow 8188883 link true /test fast_test_tiprow

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ti-chi-bot ti-chi-bot bot merged commit 1de6f3e into pingcap:master Nov 4, 2024
27 of 28 checks passed
YuJuncen added a commit to YuJuncen/tidb that referenced this pull request Jan 6, 2025
YuJuncen added a commit to YuJuncen/tidb that referenced this pull request Jan 16, 2025
@YuJuncen YuJuncen mentioned this pull request Jan 16, 2025
13 tasks
YuJuncen added a commit to YuJuncen/tidb that referenced this pull request Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

br/operator: add some debug commands to operate migrations / external storages.
3 participants