Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner, CTE, view: Fix default inline CTE which contains orderby/limit/distinct and inside of view | tidb-test=e1d0c1e615f749e7139f5be95bc4a2b8cedb7380 (#56609) #56666

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #56609

What problem does this PR solve?

Issue Number: close #56603, close #56582

Problem Summary:

What changed and how does it work?

  1. If the CTE contain orderby/limit/distinct and CTE is referenced by another CTE recursive part, it cannot be inlined . Related issue Parsing CTE error with "doesn't yet support 'ORDER BY / LIMIT / SELECT DISTINCT in recursive query block" #56603
  2. If the CTE inside of view, the consumerCount of CTE cannot be updated because the view skip the preprocessor phase in during optimizer, it also cannot judge the inline or not. So the CTE inside of view will always be not inlined. Related issue The CTE inside of view can't determine whether it can be inlined #56582

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

修复错误的 inline CTE,如果 CTE 包含 orderby/limit/distinct 子句并且被另外一个 CTE 的 recursive part 所引用。
同时去除对 view 中的 CTE 进行是否默认 inline 的优化。

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. affects-8.1 This bug affects the 8.1.x(LTS) versions. ok-to-test Indicates a PR is ready to be tested. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/planner SIG: Planner size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. type/cherry-pick-for-release-6.5-20241009-v6.5.10 labels Oct 16, 2024
@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 16, 2024
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 16, 2024
@elsa0520 elsa0520 changed the title planner, CTE, view: Fix default inline CTE which contains orderby/limit/distinct and inside of view | tidb-test=pr/2415 (#56609) planner, CTE, view: Fix default inline CTE which contains orderby/limit/distinct and inside of view | tidb-test=fd24e2c5e368ef33f9df6e156a9c35ee537be239 (#56609) Oct 16, 2024
@elsa0520
Copy link
Contributor

/test mysql-test

@elsa0520
Copy link
Contributor

/test unit-test

Copy link

tiprow bot commented Oct 16, 2024

@elsa0520: No presubmit jobs available for pingcap/tidb@release-6.5-20241009-v6.5.10

In response to this:

/test mysql-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

tiprow bot commented Oct 16, 2024

@elsa0520: No presubmit jobs available for pingcap/tidb@release-6.5-20241009-v6.5.10

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@elsa0520 elsa0520 changed the title planner, CTE, view: Fix default inline CTE which contains orderby/limit/distinct and inside of view | tidb-test=fd24e2c5e368ef33f9df6e156a9c35ee537be239 (#56609) planner, CTE, view: Fix default inline CTE which contains orderby/limit/distinct and inside of view | tidb-test=pr/2417 (#56609) Oct 16, 2024
@elsa0520
Copy link
Contributor

/test mysql-test

Copy link

tiprow bot commented Oct 16, 2024

@elsa0520: No presubmit jobs available for pingcap/tidb@release-6.5-20241009-v6.5.10

In response to this:

/test mysql-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@elsa0520 elsa0520 changed the title planner, CTE, view: Fix default inline CTE which contains orderby/limit/distinct and inside of view | tidb-test=pr/2417 (#56609) planner, CTE, view: Fix default inline CTE which contains orderby/limit/distinct and inside of view | tidb-test=pr/2418 (#56609) Oct 16, 2024
@elsa0520
Copy link
Contributor

/test mysql-test

Copy link

tiprow bot commented Oct 16, 2024

@elsa0520: No presubmit jobs available for pingcap/tidb@release-6.5-20241009-v6.5.10

In response to this:

/test mysql-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@elsa0520 elsa0520 changed the title planner, CTE, view: Fix default inline CTE which contains orderby/limit/distinct and inside of view | tidb-test=pr/2418 (#56609) planner, CTE, view: Fix default inline CTE which contains orderby/limit/distinct and inside of view | tidb-test=d18230f55697d992cae8ebc99c5fa5183d616221 (#56609) Oct 16, 2024
@elsa0520
Copy link
Contributor

/test mysql-test

Copy link

tiprow bot commented Oct 16, 2024

@elsa0520: No presubmit jobs available for pingcap/tidb@release-6.5-20241009-v6.5.10

In response to this:

/test mysql-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@elsa0520 elsa0520 changed the title planner, CTE, view: Fix default inline CTE which contains orderby/limit/distinct and inside of view | tidb-test=d18230f55697d992cae8ebc99c5fa5183d616221 (#56609) planner, CTE, view: Fix default inline CTE which contains orderby/limit/distinct and inside of view | tidb-test=0ca073415f68913ab0bab5290298b495368862ce (#56609) Oct 16, 2024
@elsa0520
Copy link
Contributor

/test mysql-test

Copy link

tiprow bot commented Oct 16, 2024

@elsa0520: No presubmit jobs available for pingcap/tidb@release-6.5-20241009-v6.5.10

In response to this:

/test mysql-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@elsa0520 elsa0520 changed the title planner, CTE, view: Fix default inline CTE which contains orderby/limit/distinct and inside of view | tidb-test=0ca073415f68913ab0bab5290298b495368862ce (#56609) planner, CTE, view: Fix default inline CTE which contains orderby/limit/distinct and inside of view | tidb-test=e1d0c1e615f749e7139f5be95bc4a2b8cedb7380 (#56609) Oct 16, 2024
@elsa0520
Copy link
Contributor

/test mysql-test

Copy link

tiprow bot commented Oct 16, 2024

@elsa0520: No presubmit jobs available for pingcap/tidb@release-6.5-20241009-v6.5.10

In response to this:

/test mysql-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented Oct 16, 2024

Codecov Report

Attention: Patch coverage is 96.29630% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (release-6.5-20241009-v6.5.10@3635e94). Learn more about missing BASE report.

Additional details and impacted files
@@                        Coverage Diff                        @@
##             release-6.5-20241009-v6.5.10     #56666   +/-   ##
=================================================================
  Coverage                                ?   73.6553%           
=================================================================
  Files                                   ?       1096           
  Lines                                   ?     352276           
  Branches                                ?          0           
=================================================================
  Hits                                    ?     259470           
  Misses                                  ?      76129           
  Partials                                ?      16677           

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Oct 16, 2024
Copy link

ti-chi-bot bot commented Oct 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, qw4990

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 16, 2024
Copy link

ti-chi-bot bot commented Oct 16, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-10-16 06:13:02.079874787 +0000 UTC m=+424379.228784611: ☑️ agreed by AilinKid.
  • 2024-10-16 06:20:19.49560583 +0000 UTC m=+424816.644515662: ☑️ agreed by qw4990.

@ti-chi-bot ti-chi-bot bot merged commit 7972ff1 into pingcap:release-6.5-20241009-v6.5.10 Oct 16, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. affects-8.1 This bug affects the 8.1.x(LTS) versions. approved lgtm ok-to-test Indicates a PR is ready to be tested. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/planner SIG: Planner size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. type/cherry-pick-for-release-6.5-20241009-v6.5.10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants