planner: make converge index merge path feel the prefer tiflash hint #56227
Conversation
|
Hi @AilinKid. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
| @@ -1356,6 +1356,10 @@ func findBestTask4DS(ds *DataSource, prop *property.PhysicalProperty, planCounte | |||
| for _, candidate := range candidates { | |||
| path := candidate.path | |||
| if path.PartialIndexPaths != nil { | |||
| // prefer tiflash, while current table path is tikv, skip it. | |||
| if ds.PreferStoreType&h.PreferTiFlash != 0 && path.StoreType == kv.TiKV { | |||
There was a problem hiding this comment.
when we step into here, we can ensure that
- tiflash is existed (replica set is checked)
- whether tiflash path can be generated successfully or not, not sure here, just keep the same logic from L1498
future work: we can sort the candidate paths according to the user's preferred hints or variables, then gen them first, if we do, output their preferred path, on the condition that the preferred path can be generated successfully. IF failed, then try next, inferior paths
|
/retest |
|
@AilinKid: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #56227 +/- ##
================================================
+ Coverage 73.4698% 75.4929% +2.0230%
================================================
Files 1600 1602 +2
Lines 443771 449127 +5356
================================================
+ Hits 326038 339059 +13021
+ Misses 97754 89550 -8204
- Partials 19979 20518 +539
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
/ok-to-test |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: elsa0520, hawkingrei, qw4990 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
|
In response to a cherrypick label: new pull request created to branch |
|
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
|
In response to a cherrypick label: new pull request created to branch |
What problem does this PR solve?
Issue Number: close #56217
Problem Summary:
What changed and how does it work?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.