-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pkg/planner, tests: set the AvoidColumnEvaluator correctly in ProjectionElimination (#55219) #55269
pkg/planner, tests: set the AvoidColumnEvaluator correctly in ProjectionElimination (#55219) #55269
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
This cherry pick PR is for a release branch and has not yet been approved by triage owners. To merge this cherry pick:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@ti-chi-bot: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-8.1 #55269 +/- ##
================================================
Coverage ? 71.1728%
================================================
Files ? 1466
Lines ? 422678
Branches ? 0
================================================
Hits ? 300832
Misses ? 101334
Partials ? 20512
Flags with carried forward coverage won't be shown. Click here to find out more.
|
check pick #55333 instead of this one |
This is an automated cherry-pick of #55219
What problem does this PR solve?
Issue Number: close #52985
Problem Summary:
The AvoidColumnEvaluator attribute in the Projection operator is used to avoid the incorrect reuse of chunks with different metadata. During the projection elimination optimization process, the setting of the AvoidColumnEvaluator attribute must be preserved if any of the consecutive projections have it set to true.
What changed and how does it work?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.