Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

statistics: fix wrong behavior for primary key' non-lite init stats #54344

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Jul 1, 2024

What problem does this PR solve?

Issue Number: ref #53710

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 1, 2024
@hawkingrei hawkingrei force-pushed the release-6.5-20231229-v6.5.6-53710 branch from 34d5e43 to c02624a Compare July 1, 2024 06:31
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 1, 2024
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jul 1, 2024
@hawkingrei hawkingrei requested a review from winoros July 1, 2024 06:44
@ti-chi-bot ti-chi-bot bot added the lgtm label Jul 1, 2024
Copy link

ti-chi-bot bot commented Jul 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, winoros

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jul 1, 2024
Copy link

ti-chi-bot bot commented Jul 1, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-07-01 06:43:25.293479408 +0000 UTC m=+1220331.778968238: ☑️ agreed by AilinKid.
  • 2024-07-01 06:44:04.822752017 +0000 UTC m=+1220371.308240843: ☑️ agreed by winoros.

Copy link

codecov bot commented Jul 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-6.5-20231229-v6.5.6@ceff3eb). Learn more about missing BASE report.

Additional details and impacted files
@@                       Coverage Diff                        @@
##             release-6.5-20231229-v6.5.6     #54344   +/-   ##
================================================================
  Coverage                               ?   73.7438%           
================================================================
  Files                                  ?       1088           
  Lines                                  ?     349907           
  Branches                               ?          0           
================================================================
  Hits                                   ?     258035           
  Misses                                 ?      75360           
  Partials                               ?      16512           

@hawkingrei
Copy link
Member Author

/retest

1 similar comment
@hawkingrei
Copy link
Member Author

/retest

@ti-chi-bot ti-chi-bot bot merged commit 0a81e4f into pingcap:release-6.5-20231229-v6.5.6 Jul 1, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants