domain: make ru_stats duration compatible with DST #52408
Conversation
|
Hi @glorv. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/ok-to-test |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #52408 +/- ##
================================================
+ Coverage 74.1411% 74.3322% +0.1910%
================================================
Files 1467 1467
Lines 354227 428958 +74731
================================================
+ Hits 262628 318854 +56226
- Misses 72389 90263 +17874
- Partials 19210 19841 +631
Flags with carried forward coverage won't be shown. Click here to find out more.
|
| count := int64(now.Sub(start) / interval) | ||
| targetDur := time.Duration(count) * interval | ||
| // use UTC timezone to calculate target time so it can be compatible with DST. | ||
| return start.In(time.UTC).Add(targetDur).In(tz) |
There was a problem hiding this comment.
No, this caller should always pass a valid tz. Anyway, I added a check to set time.Local for nil tz.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nolouch, wjhuang2016 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
|
/retest |
|
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
What problem does this PR solve?
Issue Number: close #52353
Problem Summary:
What changed and how does it work?
Use the time API to calculate the start_time of ru_stats so it can be compatible with DST(daylight saving time).
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.