server: register all status routes with mux.Router

[yzhan1]

What problem does this PR solve?

Issue Number: close #51914

Problem Summary:

Move all status routes to be registered behind mux.Router instead of splitting between the router and http.ServeMux.

What changed and how does it work?

All status routes are registered with mux.Router and mux.Router itself is registered as an HTTP handler for all routes for http.ServeMux. There should be NO behavior changes and existing test cases for affected routes should continue to pass.

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

[sre-bot]

All committers have signed the CLA.

[ti-chi-bot]

Welcome @yzhan1!

It looks like this is your first PR to pingcap/tidb 🎉.

I'm the bot to help you request reviewers, add labels and more, See available commands.

We want to make sure your contribution gets all the attention it needs!



Thank you, and welcome to pingcap/tidb. 😃

[ti-chi-bot]

Hi @yzhan1. Thanks for your PR.

I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[tiprow]

Hi @yzhan1. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[lance6716]

/ok-to-test

[codecov]

Codecov Report

Merging #51915 (70c8600) into master (531e773) will decrease coverage by 14.1985%.
Report is 97 commits behind head on master.
The diff coverage is 90.9090%.

Additional details and impacted files

@@                Coverage Diff                @@
##             master     #51915         +/-   ##
=================================================
- Coverage   70.7413%   56.5429%   -14.1985%     
=================================================
  Files          1477       1602        +125     
  Lines        438550     629278     +190728     
=================================================
+ Hits         310236     355812      +45576     
- Misses       108889     249776     +140887     
- Partials      19425      23690       +4265     

Flag	Coverage Δ
integration	37.1685% <72.7272%> (?)
unit	72.2660% <90.9090%> (+1.7223%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	53.9957% <ø> (ø)
parser	∅ <ø> (∅)
br	52.9104% <ø> (+7.0927%)	⬆️

[yzhan1]

@lance6716 @tiancaiamao @Defined2014

Could you please take a look when it's convenient for you? Much thanks!

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, lance6716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [hawkingrei,lance6716]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2024-03-20 05:28:11.719207114 +0000 UTC m=+1440918.741453503: ☑️ agreed by hawkingrei.
• 2024-03-28 02:50:36.88693646 +0000 UTC m=+2122663.909182843: ☑️ agreed by lance6716.