Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lightning: raise field length of checkpoint #51460

Merged
merged 2 commits into from
Mar 4, 2024
Merged

lightning: raise field length of checkpoint #51460

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8bef01c
lightning: raise field length of checkpoint
lance6716 Mar 4, 2024
f93bee6
fix lightning IT
lance6716 Mar 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions br/pkg/lightning/checkpoints/checkpoints.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ const WholeTableEngineID = math.MaxInt32
// remember to increase the version number in case of incompatible change.
const (
CheckpointTableNameTask = "task_v2"
CheckpointTableNameTable = "table_v8"
CheckpointTableNameTable = "table_v9"
CheckpointTableNameEngine = "engine_v5"
CheckpointTableNameChunk = "chunk_v5"
)
Expand Down Expand Up @@ -107,7 +107,7 @@ const (
status tinyint unsigned DEFAULT 30,
alloc_base bigint NOT NULL DEFAULT 0,
table_id bigint NOT NULL DEFAULT 0,
table_info text NOT NULL,
table_info longtext NOT NULL,
create_time timestamp NOT NULL DEFAULT CURRENT_TIMESTAMP,
update_time timestamp NOT NULL DEFAULT CURRENT_TIMESTAMP ON UPDATE CURRENT_TIMESTAMP,
kv_bytes bigint unsigned NOT NULL DEFAULT 0,
Expand Down
4 changes: 2 additions & 2 deletions br/tests/lightning_checkpoint/run.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ echo "******** Verify checkpoint no-op ********"
run_lightning -d "$DBPATH" --enable-checkpoint=1
run_sql "$PARTIAL_IMPORT_QUERY"
check_contains "s: $(( (1000 * $CHUNK_COUNT + 1001) * $CHUNK_COUNT * $TABLE_COUNT ))"
run_sql 'SELECT count(*) FROM `tidb_lightning_checkpoint_test_cppk`.table_v8 WHERE status >= 200'
run_sql 'SELECT count(*) FROM `tidb_lightning_checkpoint_test_cppk`.table_v9 WHERE status >= 200'
check_contains "count(*): $TABLE_COUNT"

# Start importing the tables.
Expand All @@ -113,5 +113,5 @@ echo "******** Verify checkpoint no-op ********"
run_lightning -d "$DBPATH" --enable-checkpoint=1
run_sql "$PARTIAL_IMPORT_QUERY"
check_contains "s: $(( (1000 * $CHUNK_COUNT + 1001) * $CHUNK_COUNT * $TABLE_COUNT ))"
run_sql 'SELECT count(*) FROM `tidb_lightning_checkpoint_test_cppk`.table_v8 WHERE status >= 200'
run_sql 'SELECT count(*) FROM `tidb_lightning_checkpoint_test_cppk`.table_v9 WHERE status >= 200'
check_contains "count(*): $TABLE_COUNT"
2 changes: 1 addition & 1 deletion br/tests/lightning_checkpoint_chunks/run.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ verify_checkpoint_noop() {
run_sql 'SELECT count(i), sum(i) FROM cpch_tsr.tbl;'
check_contains "count(i): $(($ROW_COUNT*$CHUNK_COUNT))"
check_contains "sum(i): $(( $ROW_COUNT*$CHUNK_COUNT*(($CHUNK_COUNT+2)*$ROW_COUNT + 1)/2 ))"
run_sql 'SELECT count(*) FROM `tidb_lightning_checkpoint_test_cpch.1234567890.bak`.table_v8 WHERE status >= 200'
run_sql 'SELECT count(*) FROM `tidb_lightning_checkpoint_test_cpch.1234567890.bak`.table_v9 WHERE status >= 200'
check_contains "count(*): 1"
}

Expand Down
Loading