Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: make sessionctx.Context depend on contexts in planner and expression #51150

Merged
merged 1 commit into from
Feb 19, 2024

Conversation

lcwangchao
Copy link
Collaborator

What problem does this PR solve?

Issue Number: close #51149

What changed and how does it work?

In this PR, we make the sessionctx.Context depends on the contexts in planner and expression:

// in pkg/sessionctx/context.go
type Context interface {
        ...
	exprctx.EvalContext
	exprctx.BuildContext
	planctx.PlanContext
        ...
}

The benefit is that we can move some methods defined in sessionctx.Context to their separate contexts. It is more clear to identify by scene the method is used.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 19, 2024
Copy link

tiprow bot commented Feb 19, 2024

Hi @lcwangchao. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

codecov bot commented Feb 19, 2024

Codecov Report

Merging #51150 (66e54db) into master (e3e0f7e) will increase coverage by 2.0996%.
Report is 4 commits behind head on master.
The diff coverage is 88.8888%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #51150        +/-   ##
================================================
+ Coverage   70.5910%   72.6907%   +2.0996%     
================================================
  Files          1467       1467                
  Lines        434739     434955       +216     
================================================
+ Hits         306887     316172      +9285     
+ Misses       108594      98856      -9738     
- Partials      19258      19927       +669     
Flag Coverage Δ
integration 49.0477% <55.5555%> (?)
unit 70.3168% <77.7777%> (-0.0700%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (ø)
parser ∅ <ø> (∅)
br 51.3276% <100.0000%> (+5.4611%) ⬆️

@lcwangchao
Copy link
Collaborator Author

/retest

Copy link

tiprow bot commented Feb 19, 2024

@lcwangchao: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lcwangchao
Copy link
Collaborator Author

/retest

Copy link

tiprow bot commented Feb 19, 2024

@lcwangchao: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Feb 19, 2024
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 19, 2024
Copy link

ti-chi-bot bot commented Feb 19, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-02-19 09:38:38.091383568 +0000 UTC m=+263606.839006664: ☑️ agreed by tangenta.
  • 2024-02-19 09:54:29.336064711 +0000 UTC m=+264558.083687822: ☑️ agreed by XuHuaiyu.

Copy link
Contributor

@lance6716 lance6716 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

for lightning part

Copy link

ti-chi-bot bot commented Feb 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lance6716, tangenta, XuHuaiyu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Feb 19, 2024
@lcwangchao
Copy link
Collaborator Author

/retest

Copy link

tiprow bot commented Feb 19, 2024

@lcwangchao: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lcwangchao
Copy link
Collaborator Author

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Feb 19, 2024
@ti-chi-bot ti-chi-bot bot merged commit 4e202a4 into pingcap:master Feb 19, 2024
37 of 39 checks passed
@lcwangchao lcwangchao deleted the context_deps branch February 19, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make sessionctx.Context depend on contexts in planner and expression
4 participants