Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: set jobs dependency by schema and table name (#49699) #51133

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #49699

What problem does this PR solve?

Issue Number: close #49498

Problem Summary:

We should also consider schema & table name before picking a DDL job to execute.

What changed and how does it work?

  • Extract ddl.runningJobs to a separate file.
  • Add AffectedSchemaNames and AffectedTableNames to model.Job.
  • Refine job depenency check.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/cherry-pick-for-release-6.5-20231229-v6.5.6 labels Feb 19, 2024
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 19, 2024
@okJiang
Copy link
Member

okJiang commented Feb 19, 2024

/retest

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Feb 19, 2024
Copy link

codecov bot commented Feb 19, 2024

Codecov Report

❗ No coverage uploaded for pull request base (release-6.5-20231229-v6.5.6@e51c033). Click here to learn what that means.
The diff coverage is 89.4117%.

Additional details and impacted files
@@                       Coverage Diff                        @@
##             release-6.5-20231229-v6.5.6     #51133   +/-   ##
================================================================
  Coverage                               ?   73.6696%           
================================================================
  Files                                  ?       1088           
  Lines                                  ?     349669           
  Branches                               ?          0           
================================================================
  Hits                                   ?     257600           
  Misses                                 ?      75549           
  Partials                               ?      16520           

@ti-chi-bot ti-chi-bot bot added the lgtm label Feb 19, 2024
Copy link

ti-chi-bot bot commented Feb 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: okJiang, tangenta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Feb 19, 2024
Copy link

ti-chi-bot bot commented Feb 19, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-02-19 06:46:00.774860252 +0000 UTC m=+253249.522483457: ☑️ agreed by okJiang.
  • 2024-02-19 06:50:13.692111064 +0000 UTC m=+253502.439734175: ☑️ agreed by tangenta.

@ti-chi-bot ti-chi-bot bot merged commit 72f3dd2 into pingcap:release-6.5-20231229-v6.5.6 Feb 19, 2024
13 checks passed
@okJiang okJiang deleted the cherry-pick-49699-to-release-6.5-20231229-v6.5.6 branch February 19, 2024 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. type/cherry-pick-for-release-6.5-20231229-v6.5.6
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants