Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

br/streamhelper: fix panic while removing task (#50869) #51105

Conversation

YuJuncen
Copy link
Contributor

This is an automated cherry-pick of #50869

What problem does this PR solve?

Issue Number: close #50839

Problem Summary:

What changed and how does it work?

This PR will do the nil check over the checkpoints.
This PR also will catch the panic generated during the subscription handler.
And some locking are acquired during handling incoming tasks.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Fixed a bug that may make TiDB panic when stopping a log backup task.

YuJuncen and others added 2 commits February 18, 2024 11:31
close pingcap#50839

Signed-off-by: Yu Juncen <yu745514916@live.com>
Signed-off-by: Yu Juncen <yu745514916@live.com>
@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 18, 2024
Copy link

tiprow bot commented Feb 18, 2024

Hi @YuJuncen. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

codecov bot commented Feb 18, 2024

Codecov Report

❗ No coverage uploaded for pull request base (release-6.5-20231229-v6.5.6@7a0b4df). Click here to learn what that means.
The diff coverage is 79.4117%.

Additional details and impacted files
@@                       Coverage Diff                        @@
##             release-6.5-20231229-v6.5.6     #51105   +/-   ##
================================================================
  Coverage                               ?   73.6705%           
================================================================
  Files                                  ?       1087           
  Lines                                  ?     349559           
  Branches                               ?          0           
================================================================
  Hits                                   ?     257522           
  Misses                                 ?      75511           
  Partials                               ?      16526           

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Feb 18, 2024
Copy link

ti-chi-bot bot commented Feb 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BornChanger, Leavrth

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm approved and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 18, 2024
Copy link

ti-chi-bot bot commented Feb 18, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-02-18 05:26:49.900881306 +0000 UTC m=+162098.648504402: ☑️ agreed by BornChanger.
  • 2024-02-18 05:28:04.36085252 +0000 UTC m=+162173.108475632: ☑️ agreed by Leavrth.

@ti-chi-bot ti-chi-bot bot merged commit e51c033 into pingcap:release-6.5-20231229-v6.5.6 Feb 18, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants