Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: force_init_stats doesn't block http api's startup (#50853) #51038

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #50853

What problem does this PR solve?

Issue Number: close #50854

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

create many tables, we can read the metrics HTTP API but cannot operator MySQL port.

  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels Feb 7, 2024
@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 7, 2024
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Feb 7, 2024
@hawkingrei
Copy link
Member

/retest

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Mar 8, 2024
Copy link

codecov bot commented Mar 8, 2024

Codecov Report

❗ No coverage uploaded for pull request base (release-6.5@2ec7e32). Click here to learn what that means.
The diff coverage is 16.6666%.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-6.5     #51038   +/-   ##
================================================
  Coverage               ?   73.6828%           
================================================
  Files                  ?       1095           
  Lines                  ?     350782           
  Branches               ?          0           
================================================
  Hits                   ?     258466           
  Misses                 ?      75718           
  Partials               ?      16598           

@ti-chi-bot ti-chi-bot bot added the lgtm label Mar 8, 2024
Copy link

ti-chi-bot bot commented Mar 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, winoros

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Mar 8, 2024
Copy link

ti-chi-bot bot commented Mar 8, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-03-08 10:25:37.655890201 +0000 UTC m=+421964.678136585: ☑️ agreed by hawkingrei.
  • 2024-03-08 11:57:45.24121714 +0000 UTC m=+427492.263463528: ☑️ agreed by winoros.

@ti-chi-bot ti-chi-bot bot merged commit fe48f7d into pingcap:release-6.5 Mar 8, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants