Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: stop pushing Agg down through Projection if substitution fail (#50932) #50991

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #50932

What problem does this PR solve?

Issue Number: close #50926

Problem Summary: planner: stop pushing Agg down through Projection if substitution fail

What changed and how does it work?

planner: stop pushing Agg down through Projection if substitution fail

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. labels Feb 5, 2024
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Feb 5, 2024
Copy link
Contributor

@AilinKid AilinKid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

conflicts

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Feb 6, 2024
Copy link

codecov bot commented Feb 19, 2024

Codecov Report

❗ No coverage uploaded for pull request base (release-7.5@4058740). Click here to learn what that means.
The diff coverage is 23.5294%.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-7.5     #50991   +/-   ##
================================================
  Coverage               ?   71.9955%           
================================================
  Files                  ?       1404           
  Lines                  ?     407771           
  Branches               ?          0           
================================================
  Hits                   ?     293577           
  Misses                 ?      94456           
  Partials               ?      19738           
Flag Coverage Δ
unit 71.9955% <23.5294%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9913% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 53.3027% <0.0000%> (?)

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 20, 2024
Copy link

ti-chi-bot bot commented Feb 20, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-02-06 12:44:17.591067083 +0000 UTC m=+274383.157836974: ☑️ agreed by AilinKid.
  • 2024-02-20 04:27:44.225601397 +0000 UTC m=+331352.973224493: ☑️ agreed by qw4990.

@qw4990
Copy link
Contributor

qw4990 commented Feb 20, 2024

/test check-dev

Copy link

tiprow bot commented Feb 20, 2024

@qw4990: No presubmit jobs available for pingcap/tidb@release-7.5

In response to this:

/test check-dev

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

@fixdb fixdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@qw4990
Copy link
Contributor

qw4990 commented Feb 20, 2024

/test check-dev

Copy link

tiprow bot commented Feb 20, 2024

@qw4990: No presubmit jobs available for pingcap/tidb@release-7.5

In response to this:

/test check-dev

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@qw4990
Copy link
Contributor

qw4990 commented Feb 20, 2024

/retest

@winoros
Copy link
Member

winoros commented Feb 20, 2024

/retest

Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

ti-chi-bot bot commented Feb 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, fixdb, qw4990, windtalker

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Feb 20, 2024
@ti-chi-bot ti-chi-bot bot merged commit 56249fd into pingcap:release-7.5 Feb 20, 2024
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants