-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mock: add more mock to avoid dm ci failed #50939
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #50939 +/- ##
================================================
+ Coverage 70.5732% 72.9699% +2.3966%
================================================
Files 1467 1467
Lines 434825 445315 +10490
================================================
+ Hits 306870 324946 +18076
+ Misses 108699 100327 -8372
- Partials 19256 20042 +786
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/retest |
Seems the problem is in #50039 you changed the behaviour of |
/retest |
/hold |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: GMHDBJD, lance6716, tangenta The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/unhold |
What problem does this PR solve?
Issue Number: close #50938
Problem Summary:
What changed and how does it work?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.