-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: fix name ambiguous check when building natural join without filter (#36012) #50904
planner: fix name ambiguous check when building natural join without filter (#36012) #50904
Conversation
47f536c
to
c399a39
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AilinKid, hawkingrei The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release-7.5 #50904 +/- ##
================================================
Coverage ? 71.9679%
================================================
Files ? 1403
Lines ? 407337
Branches ? 0
================================================
Hits ? 293152
Misses ? 94452
Partials ? 19733
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/test check-dev |
@AilinKid: No presubmit jobs available for pingcap/tidb@release-7.5 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ae75001
to
bb30521
Compare
This is an automated cherry-pick of #36012
Signed-off-by: AilinKid 314806019@qq.com
What problem does this PR solve?
Issue Number: close #32044
Problem Summary:
What is changed and how it works?
natural join without a filter may find their common columns from both sides first.
then, for every common column, we need to make sure that there is exactly one column matches the name for each side.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.