Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: use analyze scan concurrency to control index analyze #50639

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Jan 22, 2024

What problem does this PR solve?

Issue Number: close #50641

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-tests-checked size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked labels Jan 22, 2024
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 22, 2024
Copy link

ti-chi-bot bot commented Jan 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: winoros, xhebox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 22, 2024
Copy link

ti-chi-bot bot commented Jan 22, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-01-22 11:13:59.263957544 +0000 UTC m=+786480.828255249: ☑️ agreed by winoros.
  • 2024-01-22 11:15:53.662917575 +0000 UTC m=+786595.227215261: ☑️ agreed by xhebox.

Copy link

codecov bot commented Jan 22, 2024

Codecov Report

Merging #50639 (3d26a12) into master (c47f4c9) will decrease coverage by 14.6978%.
Report is 2 commits behind head on master.
The diff coverage is 50.0000%.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #50639         +/-   ##
=================================================
- Coverage   70.3373%   55.6395%   -14.6978%     
=================================================
  Files          1455       1566        +111     
  Lines        420694     588475     +167781     
=================================================
+ Hits         295905     327425      +31520     
- Misses       104469     238229     +133760     
- Partials      20320      22821       +2501     
Flag Coverage Δ
integration 36.7069% <50.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.0269% <ø> (ø)
parser ∅ <ø> (∅)
br 56.5975% <ø> (+6.0369%) ⬆️

@ti-chi-bot ti-chi-bot bot merged commit 6957170 into pingcap:master Jan 22, 2024
@hawkingrei
Copy link
Member Author

/cherrypick release-7.6

@ti-chi-bot
Copy link
Member

@hawkingrei: new pull request created to branch release-7.6: #50642.

In response to this:

/cherrypick release-7.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

/cherry-pick release-7.6

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request could not be created: failed to create pull request against pingcap/tidb#release-7.6 from head ti-chi-bot:cherry-pick-50639-to-release-7.6: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for ti-chi-bot:cherry-pick-50639-to-release-7.6."}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request"}

@ti-chi-bot
Copy link
Member

@ti-chi-bot: new pull request could not be created: failed to create pull request against pingcap/tidb#release-7.6 from head ti-chi-bot:cherry-pick-50639-to-release-7.6: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for ti-chi-bot:cherry-pick-50639-to-release-7.6."}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request"}

In response to this:

/cherry-pick release-7.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-7.6 release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

analyze_distsql_scan_concurrency is unavailable for index
4 participants