Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log backup: reset store grpc connection when encounter error #50539

Merged
merged 7 commits into from
Jan 24, 2024

Conversation

3pointer
Copy link
Contributor

@3pointer 3pointer commented Jan 18, 2024

What problem does this PR solve?

Issue Number: close #50445
Problem Summary:
advancer will cache the store grpc connection at first time connect to TiKV. This usually works well when TiKV normal scale-out/in or deploy with a domain name. but in some cases. when deploy TiKV cluster with IP address and IP changed.
the cached grpc connection will broken.

What changed and how does it work?

Disable the cached grpc connection when encounter error.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Fix the issue that TiKV IP address changed on same store makes log backup stuck.

Copy link

ti-chi-bot bot commented Jan 18, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 18, 2024
Copy link

tiprow bot commented Jan 18, 2024

Hi @3pointer. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@3pointer 3pointer changed the title log backup: reset grpc connection log backup: reset store grpc connection when encounter error Jan 18, 2024
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. do-not-merge/needs-triage-completed release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. labels Jan 18, 2024
@3pointer 3pointer marked this pull request as ready for review January 18, 2024 07:52
@ti-chi-bot ti-chi-bot bot added needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/needs-triage-completed labels Jan 18, 2024
@3pointer
Copy link
Contributor Author

/test pull-br-integration-test

Copy link

tiprow bot commented Jan 18, 2024

@3pointer: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test pull-br-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@3pointer
Copy link
Contributor Author

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Jan 18, 2024
@3pointer
Copy link
Contributor Author

/test pull-br-integration-test

Copy link

tiprow bot commented Jan 18, 2024

@3pointer: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test tiprow_fast_test

Use /test all to run all jobs.

In response to this:

/test pull-br-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

codecov bot commented Jan 18, 2024

Codecov Report

Merging #50539 (8e43c46) into master (5a2c79b) will decrease coverage by 14.6192%.
Report is 53 commits behind head on master.
The diff coverage is 42.8571%.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #50539         +/-   ##
=================================================
- Coverage   70.2391%   55.6200%   -14.6192%     
=================================================
  Files          1452       1567        +115     
  Lines        420479     588808     +168329     
=================================================
+ Hits         295341     327495      +32154     
- Misses       104780     238478     +133698     
- Partials      20358      22835       +2477     
Flag Coverage Δ
integration 36.8427% <0.0000%> (?)
unit 70.2752% <42.8571%> (+0.0360%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.0269% <ø> (ø)
parser ∅ <ø> (∅)
br 56.5454% <42.8571%> (+6.0806%) ⬆️

@3pointer
Copy link
Contributor Author

/test unit-test

Copy link

tiprow bot commented Jan 18, 2024

@3pointer: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test tiprow_fast_test

Use /test all to run all jobs.

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 24, 2024
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 24, 2024
Copy link

ti-chi-bot bot commented Jan 24, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-01-24 08:42:26.688692299 +0000 UTC m=+950188.252990003: ☑️ agreed by Leavrth.
  • 2024-01-24 09:00:54.541183395 +0000 UTC m=+951296.105481085: ☑️ agreed by YuJuncen.

Copy link

ti-chi-bot bot commented Jan 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BornChanger, Leavrth, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

ti-chi-bot bot commented Jan 24, 2024

@3pointer: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/unit-test 8e43c46 link unknown /test unit-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@BornChanger
Copy link
Contributor

/retest

@ti-chi-bot ti-chi-bot bot merged commit 0869814 into pingcap:master Jan 24, 2024
11 of 15 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #50702.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #50703.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #50704.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. ok-to-test Indicates a PR is ready to be tested. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

br: advancer owner failed to update global checkpoint
5 participants