Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metrics: Add Backfill task type and update metric query format #50249

Merged
merged 2 commits into from
Jan 10, 2024

Conversation

okJiang
Copy link
Member

@okJiang okJiang commented Jan 10, 2024

What problem does this PR solve?

Issue Number: close #49621

Problem Summary:

What changed and how does it work?

update metric query format

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

has been fixed in https://github.com/pingcap/tidb/pull/50071/files#diff-49c216fe673e1484dc2b812ffd4da6ebbbc40673598fae7a0ae3f334d87c09c2R33
backfill prefix become normal after 17:25, because of the fix
img_v3_026u_7f1ebb25-f1ca-4fea-8a0d-73e6f6cd924g

optimization
before
img_v3_026v_3b311f12-5663-4846-b2f4-9285794aa89g

after
img_v3_026v_7d031072-3840-4324-b72d-b5aa80c5027g

  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 10, 2024
@okJiang okJiang changed the title metrics: Add Backfill task type and update metric query format metrics: update metric query format Jan 10, 2024
@okJiang okJiang changed the title metrics: update metric query format metrics: Add Backfill task type and update metric query format Jan 10, 2024
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jan 10, 2024
Copy link

codecov bot commented Jan 10, 2024

Codecov Report

Merging #50249 (f695c63) into master (528a6e3) will decrease coverage by 16.4074%.
Report is 3 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #50249         +/-   ##
=================================================
- Coverage   71.8613%   55.4540%   -16.4074%     
=================================================
  Files          1442       1554        +112     
  Lines        346790     587032     +240242     
=================================================
+ Hits         249208     325533      +76325     
- Misses        77254     238798     +161544     
- Partials      20328      22701       +2373     
Flag Coverage Δ
integration 36.6834% <ø> (?)
unit 70.0749% <ø> (-1.7865%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.0269% <ø> (-2.2860%) ⬇️
parser ∅ <ø> (∅)
br 55.5618% <ø> (+4.2527%) ⬆️

Copy link

ti-chi-bot bot commented Jan 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lance6716, ywqzzy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 10, 2024
Copy link

ti-chi-bot bot commented Jan 10, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-01-10 03:51:31.686342097 +0000 UTC m=+415281.270595780: ☑️ agreed by ywqzzy.
  • 2024-01-10 04:40:57.150070024 +0000 UTC m=+418246.734323715: ☑️ agreed by lance6716.

@ti-chi-bot ti-chi-bot bot merged commit 4ed493d into pingcap:master Jan 10, 2024
@okJiang okJiang deleted the fix-metrics-49621 branch January 10, 2024 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Distributed task pending duration metrics is not reset, and ADD INDEX subtask has no prefix
3 participants