-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: use TxnCtx.InfoSchema to prevent schema inconsistency #49947
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #49947 +/- ##
================================================
- Coverage 72.0575% 68.7906% -3.2670%
================================================
Files 1437 1439 +2
Lines 345628 407669 +62041
================================================
+ Hits 249051 280438 +31387
- Misses 76506 108394 +31888
+ Partials 20071 18837 -1234
Flags with carried forward coverage won't be shown. Click here to find out more.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qw4990, tiancaiamao The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
/hold |
/unhold |
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
In response to a cherrypick label: new pull request created to branch |
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
…ap#49947) (pingcap#789) ref pingcap#41622 (cherry picked from commit 7045202)
What problem does this PR solve?
Issue Number: ref #41622
close #49751
Problem Summary:
What changed and how does it work?
The result of
sctx.GetInfoSchema().(infoschema.InfoSchema)
is not stable if the caller side is not in a transaction && snapshot_ts is not set, it just get the latest InfoSchema:tidb/pkg/session/session.go
Lines 4052 to 4074 in c20874e
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.