-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
statsitics: clear the fmsketch's map correctly (#49379) #49402
statsitics: clear the fmsketch's map correctly (#49379) #49402
Conversation
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: elsa0520, hawkingrei The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
/retest |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release-7.5 #49402 +/- ##
================================================
Coverage ? 71.9692%
================================================
Files ? 1400
Lines ? 406486
Branches ? 0
================================================
Hits ? 292545
Misses ? 94231
Partials ? 19710
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/retest |
This is an automated cherry-pick of #49379
What problem does this PR solve?
Issue Number: close #49381
Problem Summary:
What changed and how does it work?
Check List
Tests
before
after:
The new one has better CPU usage.
the left one is the old, the right one is the new.
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.