-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: inherit memory quota from user session for admin check #49260
Conversation
Hi @tangenta. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #49260 +/- ##
================================================
+ Coverage 71.0499% 72.0400% +0.9901%
================================================
Files 1368 1406 +38
Lines 402241 413413 +11172
================================================
+ Hits 285792 297823 +12031
- Misses 96570 96801 +231
+ Partials 19879 18789 -1090
Flags with carried forward coverage won't be shown. Click here to find out more.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wjhuang2016, zimulala The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
In response to a cherrypick label: new pull request created to branch |
What problem does this PR solve?
Issue Number: close #49258
Problem Summary:
ADMIN CHECK
is implemented with running queries with internal sessions.tidb_mem_quota_query
is not initialized for internal session.What changed and how does it work?
Inherit
ADMIN CHECK
session variabletidb_mem_quota_query
for internal session.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.