Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: remove duplicated pseudo bindings after loading data with BR #48806

Merged
merged 3 commits into from
Nov 24, 2023

Conversation

qw4990
Copy link
Contributor

@qw4990 qw4990 commented Nov 22, 2023

What problem does this PR solve?

Issue Number: ref #46527

Problem Summary: planner: remove duplicated pseudo bindings after loading data with BR

What changed and how does it work?

planner: remove duplicated pseudo bindings after loading data with BR

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 22, 2023
Copy link

tiprow bot commented Nov 22, 2023

Hi @qw4990. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Nov 22, 2023
Copy link

codecov bot commented Nov 22, 2023

Codecov Report

Merging #48806 (7feea14) into master (26db590) will increase coverage by 1.6477%.
Report is 2 commits behind head on master.
The diff coverage is 89.9521%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #48806        +/-   ##
================================================
+ Coverage   71.0004%   72.6481%   +1.6477%     
================================================
  Files          1367       1392        +25     
  Lines        404899     411625      +6726     
================================================
+ Hits         287480     299038     +11558     
+ Misses        97382      93666      -3716     
+ Partials      20037      18921      -1116     
Flag Coverage Δ
integration 43.6360% <55.0239%> (?)
unit 71.0073% <84.6890%> (+0.0069%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9663% <ø> (ø)
parser ∅ <ø> (∅)
br 48.8297% <59.2592%> (-4.2511%) ⬇️

Copy link

ti-chi-bot bot commented Nov 24, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, Leavrth

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 24, 2023
Copy link

ti-chi-bot bot commented Nov 24, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-11-22 10:03:30.109234917 +0000 UTC m=+398638.774461112: ☑️ agreed by Leavrth.
  • 2023-11-24 06:34:52.384364627 +0000 UTC m=+558921.049590821: ☑️ agreed by hawkingrei.

Copy link

tiprow bot commented Nov 24, 2023

@qw4990: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
tiprow_fast_test 7feea14 link true /test tiprow_fast_test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ti-chi-bot ti-chi-bot bot merged commit a0f5376 into pingcap:master Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants