-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: fix hang when the analyze worker unexpectedly exits #48365
Conversation
40ee70b
to
03e6733
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #48365 +/- ##
================================================
+ Coverage 71.3892% 73.1602% +1.7709%
================================================
Files 1402 1425 +23
Lines 406861 416665 +9804
================================================
+ Hits 290455 304833 +14378
+ Misses 96465 93032 -3433
+ Partials 19941 18800 -1141
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hi-rustin, winoros The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
/cherrypick release-7.5 |
@hawkingrei: new pull request created to branch In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
What problem does this PR solve?
Issue Number: close #48356
Problem Summary:
What is changed and how it works?
if analyze worker or result handler unexpectedly exit. it is possible to hang in the place of sending task.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.