Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: fix hang when the analyze worker unexpectedly exits #48365

Merged
merged 5 commits into from
Nov 8, 2023

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Nov 7, 2023

What problem does this PR solve?

Issue Number: close #48356

Problem Summary:

What is changed and how it works?

if analyze worker or result handler unexpectedly exit. it is possible to hang in the place of sending task.

image

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 7, 2023
@hawkingrei hawkingrei force-pushed the fix_hang branch 2 times, most recently from 40ee70b to 03e6733 Compare November 7, 2023 10:34
Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Merging #48365 (8709330) into master (8071fc7) will increase coverage by 1.7709%.
Report is 12 commits behind head on master.
The diff coverage is 77.7777%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #48365        +/-   ##
================================================
+ Coverage   71.3892%   73.1602%   +1.7709%     
================================================
  Files          1402       1425        +23     
  Lines        406861     416665      +9804     
================================================
+ Hits         290455     304833     +14378     
+ Misses        96465      93032      -3433     
+ Partials      19941      18800      -1141     
Flag Coverage Δ
integration 43.9370% <55.5555%> (?)
unit 71.8243% <77.7777%> (+0.4350%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9874% <ø> (ø)
parser ∅ <ø> (∅)
br 48.6669% <ø> (-4.3734%) ⬇️

Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 8, 2023
@hawkingrei hawkingrei requested a review from qw4990 November 8, 2023 08:12
Copy link
Member

@Rustin170506 Rustin170506 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
Copy link

ti-chi-bot bot commented Nov 8, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hi-rustin, winoros

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 8, 2023
Copy link

ti-chi-bot bot commented Nov 8, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-11-08 07:38:52.159968788 +0000 UTC m=+3629929.747078931: ☑️ agreed by winoros.
  • 2023-11-08 10:12:21.840112722 +0000 UTC m=+3639139.427222867: ☑️ agreed by hi-rustin.

@hawkingrei
Copy link
Member Author

/retest

@ti-chi-bot ti-chi-bot bot merged commit 92f071a into pingcap:master Nov 8, 2023
@hawkingrei hawkingrei deleted the fix_hang branch November 8, 2023 13:52
@hawkingrei
Copy link
Member Author

/cherrypick release-7.5

@ti-chi-bot
Copy link
Member

@hawkingrei: new pull request created to branch release-7.5: #48445.

In response to this:

/cherrypick release-7.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Nov 8, 2023
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SQL hang for analyze table when exceed tidb_mem_quota_analyze
4 participants