resource_control: add runaway metrics #47360
Conversation
Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>
|
Hi @CabinfeverB. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #47360 +/- ##
================================================
+ Coverage 71.8856% 73.6701% +1.7845%
================================================
Files 1398 1426 +28
Lines 405057 422954 +17897
================================================
+ Hits 291178 311591 +20413
+ Misses 94273 92261 -2012
+ Partials 19606 19102 -504
Flags with carried forward coverage won't be shown. Click here to find out more.
|
domain/resourcegroup/runaway.go
Outdated
| @@ -252,6 +253,7 @@ func (rm *RunawayManager) DeriveChecker(resourceGroupName, originalSQL, sqlDiges | |||
| if group.RunawaySettings == nil && rm.activeGroup[resourceGroupName] == 0 { | |||
| return nil | |||
| } | |||
| metrics.RunawayCheckerCounter.WithLabelValues(resourceGroupName, "hit", "").Inc() | |||
There was a problem hiding this comment.
It's better to remove WithLabelValues. in most cases, the group name is not changed.
Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>
Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>
Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>
Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>
|
PTAL @nolouch |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: glorv, nolouch The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test mysql-test |
|
@glorv: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What problem does this PR solve?
Issue Number: ref #43691
Problem Summary:
What is changed and how it works?
add metrics for runaway manager.
format the resource-control grafana json.
Check List
Tests
Unit test
Integration test
Manual test (add detailed scripts or steps below)
No need to test
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.