Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

variable: always truncate tidb_session_alias when it is not a valid value #46707

Merged
merged 1 commit into from
Sep 12, 2023

Conversation

lcwangchao
Copy link
Collaborator

@lcwangchao lcwangchao commented Sep 6, 2023

What problem does this PR solve?

Issue Number: ref #46071

What is changed and how it works?

after discussing, we need always truncate value when setting tidb_session_alias even if the value is not valid.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@lcwangchao lcwangchao requested a review from a team as a code owner September 6, 2023 03:24
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 6, 2023
@lcwangchao lcwangchao changed the title variable: always truncate tidb_session_alias when it is not a valid… variable: always truncate tidb_session_alias when it is not a valid value Sep 6, 2023
@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Merging #46707 (50315c0) into master (6e7f36b) will increase coverage by 0.8638%.
Report is 85 commits behind head on master.
The diff coverage is 100.0000%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #46707        +/-   ##
================================================
+ Coverage   73.3586%   74.2225%   +0.8638%     
================================================
  Files          1315       1350        +35     
  Lines        395675     415634     +19959     
================================================
+ Hits         290262     308494     +18232     
- Misses        86932      88712      +1780     
+ Partials      18481      18428        -53     
Flag Coverage Δ
integration 28.7789% <57.1428%> (?)
unit 74.8765% <100.0000%> (+1.5178%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.0444% <ø> (ø)
parser 87.0740% <ø> (+2.1158%) ⬆️
br 50.0241% <ø> (-2.4134%) ⬇️

@lcwangchao
Copy link
Collaborator Author

/retest

1 similar comment
@lcwangchao
Copy link
Collaborator Author

/retest

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Sep 7, 2023
@lcwangchao
Copy link
Collaborator Author

/retest

Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 11, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 11, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-09-07 09:30:18.136530442 +0000 UTC m=+2610582.685546414: ☑️ agreed by CbcWestwolf.
  • 2023-09-11 09:00:26.725724252 +0000 UTC m=+259808.650280632: ☑️ agreed by bb7133.

@easonn7
Copy link

easonn7 commented Sep 12, 2023

/approve

@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 12, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bb7133, CbcWestwolf, easonn7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Sep 12, 2023
@lcwangchao
Copy link
Collaborator Author

/retest

@ti-chi-bot ti-chi-bot bot merged commit 063a5b5 into pingcap:master Sep 12, 2023
@lcwangchao lcwangchao deleted the session_alais_truncate branch September 12, 2023 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants