br: avoid possible infinite loop checking tikv gc and scheduling status (#46078) #46195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: BornChanger <dawn_catcher@126.com>
12 tasks
|
/retest |
1 similar comment
|
/retest |
BornChanger
approved these changes
Aug 17, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release-6.5 #46195 +/- ##
================================================
Coverage ? 73.6856%
================================================
Files ? 1084
Lines ? 347882
Branches ? 0
================================================
Hits ? 256339
Misses ? 75081
Partials ? 16462 |
Leavrth
approved these changes
Aug 17, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BornChanger, Leavrth The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #46078
What problem does this PR solve?
Issue Number: close #46073
Problem Summary:
What is changed and how it works?
To make sure TiKV gc and schedule status check can exit in 10 mins.
Check List
Tests
Repro the tikv shutdown at backup execution time, and make sure ebs br backup will fail with timeout.
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.