Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: Fix different behaviors with MySQL when comparing datetime column with numeric constant | tidb-test=pr/2198 (#45945) #46087

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #45945

What problem does this PR solve?

Issue Number: close #38361

Problem Summary: When compare datetime/timestamp column with numeric constant, try convert numeric constant to timestamp datetime, do nothing if conversion failed.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: yibin <huyibin@pingcap.com>
Signed-off-by: yibin <huyibin@pingcap.com>
Signed-off-by: yibin <huyibin@pingcap.com>
Signed-off-by: yibin <huyibin@pingcap.com>
Signed-off-by: yibin <huyibin@pingcap.com>
Signed-off-by: yibin <huyibin@pingcap.com>
Signed-off-by: yibin <huyibin@pingcap.com>
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR. labels Aug 15, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 15, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign yangkeao for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yibin87
Copy link
Contributor

yibin87 commented Aug 15, 2023

/test unit-test

@tiprow
Copy link

tiprow bot commented Aug 15, 2023

@yibin87: No presubmit jobs available for pingcap/tidb@release-7.1

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yibin87
Copy link
Contributor

yibin87 commented Aug 15, 2023

/test unit-test

@tiprow
Copy link

tiprow bot commented Aug 15, 2023

@yibin87: No presubmit jobs available for pingcap/tidb@release-7.1

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yibin87
Copy link
Contributor

yibin87 commented Aug 15, 2023

/test unit-test

@tiprow
Copy link

tiprow bot commented Aug 15, 2023

@yibin87: No presubmit jobs available for pingcap/tidb@release-7.1

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: yibin <huyibin@pingcap.com>
@hawkingrei hawkingrei changed the title expression: Fix different behaviors with MySQL when comparing datetime column with numeric constant | tidb-test=pr/2196 (#45945) expression: Fix different behaviors with MySQL when comparing datetime column with numeric constant | tidb-test=pr/2198 (#45945) Aug 15, 2023
@hawkingrei
Copy link
Member

/test all

@tiprow
Copy link

tiprow bot commented Aug 15, 2023

@hawkingrei: No presubmit jobs available for pingcap/tidb@release-7.1

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yibin87
Copy link
Contributor

yibin87 commented Aug 15, 2023

/cherry-pick-invite

@ti-chi-bot
Copy link
Member Author

@yibin87 Please accept the invitation then you can push to the cherry-pick pull requests.
Comment with "/cherry-pick-invite" if the invitation is expired.
https://github.com/ti-chi-bot/tidb/invitations

Signed-off-by: yibin <huyibin@pingcap.com>
@ti-chi-bot ti-chi-bot bot removed the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 15, 2023
@ti-chi-bot ti-chi-bot bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 15, 2023
Signed-off-by: yibin <huyibin@pingcap.com>
@yibin87
Copy link
Contributor

yibin87 commented Aug 16, 2023

/test unit-test

@tiprow
Copy link

tiprow bot commented Aug 16, 2023

@yibin87: No presubmit jobs available for pingcap/tidb@release-7.1

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 16, 2023

@ti-chi-bot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/mysql-test f0eea92 link true /test mysql-test
idc-jenkins-ci-tidb/unit-test f0eea92 link true /test unit-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@windtalker
Copy link
Contributor

close as duplicate with #46129

@windtalker windtalker closed this Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants